cime DART testing#4985
Open
kdraeder wants to merge 4 commits into
Open
Conversation
Changes are needed in multiple components: cesm, cime, cmeps, mom/MOM6.
The branches are labeled with DART_lowres_{component}.
CIME/SystemTests/mcc.py
Set ensemble size from test name (or default).
kdraeder
added
ty: enhancement
tp: system tests
topic: tests
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
=======================================
Coverage 28.47% 28.48%
=======================================
Files 262 262
Lines 38446 38486 +40
Branches 8138 8144 +6
=======================================
+ Hits 10948 10961 +13
- Misses 26237 26265 +28
+ Partials 1261 1260 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
If I shouldn't push to this branch, which one would be a better choice? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make mcc.py handle ensembles of the size DART uses, typically up to 100 instances.
Large ensembles have caused problems in the past, which were not visible in tests of very small ensembles.
A current example is that my tests of these changes revealed a limitation in the testing code,
which is described in the issues and PRs listed below.
The short version is that for a model_size + ensemble_size test which cannot fit on one node,
MAX_TASKS_PER_NODE must be set so that no instances are laid out onto 2 nodes.
For example, if each of 4 instances requires 50 PEs and a node has 128 PEs,
then MAX_TASKS_PER_NODE must = 100, so that 2 instances are put on each node
and none are split across the 2 nodes.
Several issues and PRs in other components refer to this overview issue
because changes were required there to implement the large ensemble testing.
CESM PR #398
ccs_config PR # 285
MOM6 #413
CMEPS #641
Checklist